Repository navigation
fix(reader): a decimal flat-node bound read as text no longer fails a filtered scan (#583) - #704
Merged
Merged
Conversation
… filtered scan (#583) A flat node's stats scalar is decoded without the column dtype, so a decimal min/max arrived as a String and Compare threw VortexException during chunk pruning. canPrune now treats a non-BigDecimal decimal bound as absent. Also pins decimal MIN/MAX push-down (whole table and filtered) in DecimalSumTest and a small-file filtered read of a vortex-jni decimal file. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011fRbYsrGtpKHp9APhU8qDV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A flat node's stats scalar is decoded without the column dtype, so a decimal bound reached
Compareas aStringand a filtered scan threwVortexException.canPrunenow treats a non-BigDecimaldecimal bound as absent (no pruning from it).Tests: unit test fails without the guard (
... String ... is not comparable to a decimal); decimal MIN/MAX push-down cases (whole table, filtered) inDecimalSumTest; small-file filtered read of a vortex-jni decimal file.clean verifyof core, reader, writer, calcite, integration passed before the rebase; reader, writer, calcite re-verified after it.The last open #583 item, nullable text with nulls training FSST on placeholder rows, needs validity inside the encodings and moves to #650.
🤖 Generated with Claude Code
https://claude.ai/code/session_011fRbYsrGtpKHp9APhU8qDV